Re: [g-a-devel] Happy patch bonanza

[Bill Haneman <Bill Haneman Sun COM>]

Hi Enrico:

Thanks a bunch for those patches!

I have a question about the utf-8/latin1 patch...
...
> 
> recode.patch
>   Patch for gnome-speech festival driver.  When one of the Italian
>   voices is requested, switches the g_io output channel to latin1
>   instead of utf-8.

Are you sure this is sufficient?  Don't you need to call g_convert in
order to convert the strings from the gnome-speech client to latin1
before passing them to the engine?

>   This fixes the Italian voices!  Hooray!!

That's great news.  But it seems to me that there should be something
more general and robust than just checking the voice string, in order to
determine the correct encoding which the festival engine/voice expects.

Note also that this problem seems to have been introduced on May 14 when
Will explicitly changed the encoding on the iochannel from ISO-8859-1 to
UTF-8.  Will, can you explain why you did that?


Bill


> 
> Ciao,
> 
> Enrico
> 
> -- 
> GPG key: 1024D/797EBFAB 2000-12-05 Enrico Zini <enrico debian org>
> 
> ______________________________________________________________________
> _______________________________________________
> Gnome-accessibility-devel mailing list
> Gnome-accessibility-devel gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-accessibility-devel