Re: can't build HEAD version of at-spi

[Bill Haneman <bill haneman sun com>]

Thanks Vitaly;

gcc accepts the construction but you are right, it is incorrect.  Thanks
for finding the problem!

Please go ahead and apply the patch if you like.

best regards,

Bill


On Wed, 2002-10-23 at 16:43, Vitaly Tishkov wrote:
> Hi,
> 
> I can't build the HEAD version of at-spi:
> 
> .........
> gmake[2]: Entering directory `/set/gtk/src/SunOS/at-spi/registryd'
> cc -DHAVE_CONFIG_H -I. -I. -I.. -I..                     -I..
> -I../libspi            -I../libspi
> -I/set/gtk/build/SunOS/include/glib-2.0
> -I/set/gtk/build/SunOS/lib/glib-2.0/include
> -I/set/gtk/build/SunOS/include/atk-1.0 -I/set/gtk/build/SunOS/include/pango-1.0
> -I/set/gtk/build/SunOS/include/gtk-2.0
> -I/set/gtk/build/SunOS/lib/gtk-2.0/include
> -I/set/gtk/build/SunOS/include/libxml2
> -I/set/gtk/build/SunOS/include/bonobo-activation-2.0
> -I/set/gtk/build/SunOS/include/libbonobo-2.0
> -I/set/gtk/build/SunOS/include/linc-1.0
> -I/set/gtk/build/SunOS/include/orbit-2.0      -g -c deviceeventcontroller.c
> "deviceeventcontroller.c", line 837: warning: enum type mismatch: op "="
> "deviceeventcontroller.c", line 841: warning: enum type mismatch: op "="
> "deviceeventcontroller.c", line 1266: prototype mismatch: 1 arg passed, 2
> expected
> "deviceeventcontroller.c", line 1310: prototype mismatch: 1 arg passed, 2
> expected
> "deviceeventcontroller.c", line 1583: warning: syntax error:  empty declaration
> cc: acomp failed for deviceeventcontroller.c
> gmake[2]: *** [deviceeventcontroller.o] Error 2
> gmake[2]: Leaving directory `/set/gtk/src/SunOS/at-spi/registryd'
> .............
> 
> I looked into devicecontroller.c and found that gettimeofday() is called with 2
> args sometimes and with 1 argument twice (where compile time errors issued).
> The patch in the attachment fixes the problem but  I'm not sure that the patch
> is correct...
> 
> Regards,
>     Vitaly.
> ----
> 

> Index: registryd/deviceeventcontroller.c
> ===================================================================
> RCS file: /cvs/gnome/at-spi/registryd/deviceeventcontroller.c,v
> retrieving revision 1.49
> diff -u -r1.49 deviceeventcontroller.c
> --- registryd/deviceeventcontroller.c	21 Oct 2002 19:41:46 -0000	1.49
> +++ registryd/deviceeventcontroller.c	23 Oct 2002 15:31:23 -0000
> @@ -1263,7 +1263,7 @@
>  		bounce_delay = dec_xkb_get_bouncekeys_delay (controller); 
>                  if (bounce_delay)
>  		{
> -			gettimeofday (&tv);
> +			gettimeofday (&tv, NULL);
>  			elapsed_msec =
>  				(tv.tv_sec - priv->last_release_time.tv_sec) * 1000
>  				+ (tv.tv_usec - priv->last_release_time.tv_usec) / 1000;
> @@ -1307,7 +1307,7 @@
>  		slow_delay = dec_xkb_get_slowkeys_delay (controller);
>  		if (slow_delay)
>  		{
> -			gettimeofday (&tv);
> +			gettimeofday (&tv, NULL);
>  			elapsed_msec =
>  				(tv.tv_sec - priv->last_press_time.tv_sec) * 1000
>  				+ (tv.tv_usec - priv->last_press_time.tv_usec) / 1000;