Re: Accessibility of Gnome panel / How to end session via keyboard

["Padraig O'Briain" <Padraig Obriain Sun COM>]

John,

I am not sure what is going on.

When I created the patch I sent you I was using gnome-2-2 but have since moved 
to using CVS HEAD for most modules including gnome-panel.

My proposed patch should have changed only the menu popped up by Alt+F1.

The behavior is different with gnome-panel 2.3.x and if bug 72008 is to be 
believed the menu items will have mnemonics.

Padraig

> To: "Padraig O'Briain" <Padraig Obriain sun com>
> Cc: <gnome-accessibility-list gnome org>
> Subject: Re: Accessibility of Gnome panel / How to end session via keyboard
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> X-Priority: 3
> X-MSMail-Priority: Normal
> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165
> 
> Padraig / ALL,
> 
> I attempted to apply this patch after some initial stumbling around with the
> installation of sources and such (see my other thread); but even after I got
> gnome-panel to compile on my system without errors; I can't seem to get the
> patch to give the correct results.
> 
> 1) I manually edited the menu.c file and
> 2) added the underscore (_) in front of the Log Out string ;
> 3) recompiled the source...
> 4) copied the gnome-panel binary to my usr/bin directory and
> 5) startx to run gnome.
> 
> Everything loaded fine... but the main menu on gnome didn't accept the hot
> key of an L..
> I tried to use the mouse to open the menu... then hit L, SHIFT-L, ALT-L,
> CTRL-L and all other SHIFT/ALT/CTRL combos... none worked.
> 
> So, I exited gnome using the mouse and logout and recompiled... then did a
> 6) make install
> 
> and re-ran gnome.
> 
> Now the main panel disappeared all together. However, I could still bring up
> the panel using <ALT-F1>; but it still didn't accept the L hot key like I
> expected.
> 
> So, I exited and reinstalled the gnome-panel from Mandrake's RPM on CD.
> Verified gnome-panel was back in proper working order.
> 
> I went back into menu.c and edited that same line... this time trying
> _("Zitt _Log Out"));
> 
> and recompiled, copied, and re-ran gnome...
> 
> The logout menu item did not change it's text... and the L hot key still did
> not work.
> 
> I'm fairly sure missing something obvious.
> I assume PANEL_STOCK_LOGOUT is a template which is a image that has to be
> manually modified to show any string changes?
> If so; why didn't the hot key work?
> 
> I'm running gnome-panel 2.2.0 not the latest (2.3.??)... is this hotkey
> feature part of a later version of gnome?
> 
> Any ideas?
> John
> 
> ----- Original Message ----- 
> From: "Padraig O'Briain" <Padraig Obriain sun com>
> Sent: Friday, June 27, 2003 12:46 AM
> Subject: Re: Accessibility of Gnome panel / How to end session via keyboard
> 
> 
> > Patch to achieve this hack attached.
> >
> > Padraig
> >
> > >
> > >
> > > > If we look at Microshaft's implementation... you can do the following:
> > > > <CTRL><ESC> (brings up start menu)
> > > > S <selects Shutdown>
> > > > U <selects Shutdown> or R <selects Reboot>
> > > > <ENTER> (confirms selection)
> > > >
> > > > Ideally, I'd like to see Gnome do simular things:
> > > > <ALT><F1> (brings up foot menu>
> > > > L <selects Log Off>
> > > > etc.
> > > >
> > > > IF I wanted to hack in this capability; where in the source code would
> I
> > look?
> > > Look in gnome-panel/menu.c.  I think just inserting underscores in
> > > front of the characters you want to make shortcuts, in the menu item
> labels,
> > > may do the trick.  I am checking now (but have to rebuild things first).
> > >
> > > - Bill
> > > > John
> 
> 
> 
> ----------------------------------------------------------------------------
> ----
> 
> 
> > Index: menu.c
> > ===================================================================
> > RCS file: /cvs/gnome/gnome-panel/gnome-panel/menu.c,v
> > retrieving revision 1.642.2.8
> > diff -u -p -r1.642.2.8 menu.c
> > --- menu.c 10 Mar 2003 02:01:41 -0000 1.642.2.8
> > +++ menu.c 27 Jun 2003 07:44:52 -0000
> > @@ -3567,7 +3567,7 @@ create_desktop_menu (GtkWidget *menu, gb
> >
> >   menuitem = gtk_image_menu_item_new ();
> >   setup_stock_menu_item (
> > - menuitem, panel_menu_icon_get_size (), PANEL_STOCK_LOGOUT, _("Log
> Out"));
> > + menuitem, panel_menu_icon_get_size (), PANEL_STOCK_LOGOUT, _("_Log
> Out"));
> >   gtk_menu_shell_append (GTK_MENU_SHELL (menu), menuitem);
> >   g_signal_connect (menuitem, "activate",
> >     G_CALLBACK (panel_action_logout), 0);
> >
>