Re: string-freeze exception request: add translated strings to GOK

[Christian Rose <menthos gnome org>]

ons 2003-10-01 klockan 22.14 skrev Bill Haneman:
> > > (1) mark g_warning strings for translation: we may be able to reduce
> > > this to a single string and re-use, but the patch below uses two
> > > different strings (more informative).
> > 
> > My personal opinion is that marking these g_warnings for translation
> > could wait until after you've branched,
> 
> Sure, no problem.  I just don't want them to get forgotten :-)

That's why we have Bugzilla. Is this issue in a report somewhere?


> > > +				g_warning (_("Your keyboard geometry cannot be determined"));
> > [...]
> > > +		g_warning (_("Your keyboard geometry cannot be determined!\n"));
> > 
> > I don't see why these messages need to be different.
>
> Hmm, ok, the difference is meaningful for diagnostic purposed (one is
> failure of the XKB extension generally, one is failure of a specific XKB
> API).

I don't really see how one added exclamation mark and newline signifies
that difference to the user?!


> > > -	/* TODO: these strings are useless without localization, but string freeze prevents inclusion */
> > >  	gok_keyboard_add_keys_from_charstrings (pKeyboard, 
> > > -						"level 0|abcdefghijklmnopqrstuvwxyz1234567890-=[];'#\\,./",
> ...
> 
> > This absolutely need a comment for translators(*), so that they know
> > what on earth this is about and how it should be "translated"
> 
> There's a long note to the translators in the preceding comment.  Isn't
> that supposed to get merged into the po files by intltool?

Oh, sorry, I missed the big comment, I obviously didn't see it in the
patch.
Just one note though; any comments that gettext should extract and that
translators need to see should be immediately preceding the message.
I.e. empty or non-empty lines between the end of the comment and the
start of the message won't work AFAIK.


[...]
> > But to repeat myself again, I don't see any strong reason this needs to
> > be added to the stable branch.
> 
> When will the GTP folks be looking at 2.5?  One motivation was to get
> the string exposed to the translators ASAP.

As soon as we have the new status pages code and/or create new pages
showing 2.6 modules. I don't know which needs to be coming first, but
we'll have them soon(tm).


Christian