[gnome-db] Re: libgda/libgnomedb 1.1.99 released

[Rodrigo Moya <rodrigo gnome-db org>]

On Mon, 2004-10-11 at 09:41 +0200, Tomasz Kłoczko wrote:
> On Mon, 11 Oct 2004, Rodrigo Moya wrote:
> 
> >> Attached patches for this version. Aprove for commit (or refuse):
> >>
> >> - libgda-gettext.patch: remove providers/sybase/main.c from po/POTFILES.in
> >>    (no included in dist tar ball and also translations from this file are
> >>    never used by libgda),
> >>
> >> - libgda-ac_fixes.patch: added fixes for latest autoheaders (include in
> >>    situ autoheaders prototypes),
> >>
> >> - libgda-make-jN.patch: if used in *_LDADD variable *.la file is from
> >>    current directory do not list them with full path and so not make
> >>    empty sql_parser_test_DEPENDENCIES variable (this fix allow build
> >>    libgda using "make -j<N>"),
> >>
> >> - libgda-xbase.patch: fixes for build xbase backend module.
> >>
> > you forgot to attach the patches :)
> 
> Sorry .. :o>
> 
looks good, some minor comments:

> ltds"
> -                                       AC_DEFINE(HAVE_FREETDS)
> +                                       AC_DEFINE(HAVE_FREETDS, 1,
> [Have freetds])
>                                         ;;
>                                 *)      AC_MSG_WARN($freetdsvercheck
> not supprted - backend not used)
> 
while you're at it, could you fix that supprted typo?

> @@ -31,8 +31,7 @@
>  
>  sql_parser_test_SOURCES=sql_parser_test.c
>  sql_parser_test_LDFLAGS = $(LIBGDA_LIBS)
> -sql_parser_test_DEPENDENCIES =
> -sql_parser_test_LDADD = $(top_builddir)/libsql/libgdasql.la
> +sql_parser_test_LDADD = libgdasql.la
> 
the $(top_builddir)... part is needed for 'make dist', so should not be
removed.

The rest looks ok, so please commit with the above mentioned changes,
and thanks :)
-- 
Rodrigo Moya <rodrigo gnome-db org>