Re: [gnome-db] Patch Postgres provider.

[Vivien Malerba <vmalerba gmail com>]

On Wed, 27 Oct 2004 16:52:30 +1000, Bas Driessen <bas driessen xobas com> wrote:
>  Hello,
>  
>  Attached a patch for the postgres provider. I can't find any "patch
> instructions" on your web pages, so not sure about the procedure, so please
> advise if it is not conform the rules.
>  
>  Anyway, when using gda_data_model_append_row and a column name is a
> reserved name like "desc" or "typeid", the INSERT query is unsuccessful and
> returns an error. What this patch does is place " arround the column names.
> So:
>  
>  INSERT INTO parts(part_id, desc, price) VALUES (123, 'Test', 12.34)
>  
>  becomes
>  
>  INSERT INTO parts("part_id", "desc", "price") VALUES (123, 'Test', 12.34)
>  
>  and all works fine. 
>  
>  Sure, it is probably not a good idea to use reserved names for column
> names, but people will be using them not knowing that some names are
> special.
>  
>  Thanks,
>  Bas.
>  

Seems ok for me; I'll commit it to CVS soon.

Vivien