Re: [gnome-db] [PATCH] - Patch libgnomedb.spec.in for 1.1.99

[Rodrigo Moya <rodrigo gnome-db org>]

On Fri, 2004-10-22 at 00:59 +0300, David Hollis wrote:
> On Mon, 2004-10-18 at 12:57 +0200, Rodrigo Moya wrote:
> > On Wed, 2004-10-13 at 09:12 -0400, David Hollis wrote:
> > > On Wed, 2004-10-13 at 12:52 +0200, Rodrigo Moya wrote:
> > > > On Tue, 2004-10-12 at 18:48 -0400, David Hollis wrote:
> > > > > This patch incorporates fixes that RedHat added for libgnomedb as well as
> > > > > including changes made during the 1.1.x series.  Please apply so RPMS will
> > > > > build properly with the upcoming 1.2 release.
> > > > > 
> > > > why do we need to add an Epoch to the version?
> > > RedHat added that.  I'm not certain exactly why unfortunately.
> > > 
> > if we don't know what it's for, I guess it's better to not use it. It
> > prepends a $epoch to all version numbers, so the package would be
> > 1-1.2-release, which is not what we want.
> > 
> > So, could you please provide a new patch without the epoch stuff and
> > with my other comment fixed, please?
> > 
> > thanks
> 
> Sorry to take so long on this, I'm out of the country and on extremely
> slow Internet.  I removed the Epoch, added in the gtk-doc, not sure why
> RH had disabled it.
> 
sorry also for taking so long to answer :)

it looks ok, only one thing, which is:

> +%dir %{_includedir}/libgnomedb-1.1/
> +%{_includedir}/libgnomedb-1.1/*
> 
I changed it to:

%dir
%{_includedir}/libgnomedb- GNOMEDB_MAJOR_VERSION@  GNOMEDB_MINOR_VERSION@/
%{_includedir}/libgnomedb- GNOMEDB_MAJOR_VERSION@  GNOMEDB_MINOR_VERSION@/*

so that we don't need to change it for every version.

So, this is now in CVS HEAD
-- 
Rodrigo Moya <rodrigo gnome-db org>