Problem with gnome.m4 aclocal macro.



Hi!

New gnome.m4 has one hidden bug. When you call GNOME_INIT without
additional inits (like applets or capplet), position parameter expands
to empty list while generating configure, producing syntax error in for.
I wrapped it in variable. Diff is attached.

Regards,
Tomislav
Index: macros/ChangeLog
===================================================================
RCS file: /cvs/gnome/gnome-common/macros/ChangeLog,v
retrieving revision 1.153
diff -u -r1.153 ChangeLog
--- macros/ChangeLog	1999/03/10 01:10:10	1.153
+++ macros/ChangeLog	1999/03/10 21:10:47
@@ -1,3 +1,9 @@
+1999-03-10  Tomislav Vujec  <tvujec@carnet.hr
+
+	* gnome.m4 (GNOME_INIT_HOOK): Wrapped position parameter in testing
+	for additional inits. It gets expanded while generating configure,
+	resulting in an empty parameter list - syntax error in for statement.
+
 1999-03-09  Raja R Harinath  <harinath@cs.umn.edu>
 
 	* gnome.m4 (GNOME_INIT): Add a new paramater, which is passed to
Index: macros/gnome.m4
===================================================================
RCS file: /cvs/gnome/gnome-common/macros/gnome.m4,v
retrieving revision 1.20
diff -u -r1.20 gnome.m4
--- macros/gnome.m4	1999/03/10 01:10:12	1.20
+++ macros/gnome.m4	1999/03/10 21:10:47
@@ -96,7 +96,8 @@
 	fi
 
 	if test -n "$3"; then
-	  for i in $3; do
+          n="$3"
+	  for i in $n; do
 	    AC_MSG_CHECKING(extra library $i)
 	    case $i in 
 	      applets)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]