Re: [patch] fix mkdir(NULL) in gnome_metadata



On Thursday, August 30, 2001, at 08:23  PM, Miguel de Icaza wrote:

Oops. Should just be "database", not "database ()".

This explains the strange stat(NULL) that Alex Larsson was seeing in
Nautilus. I also worry that the constant locking and unlocking on every
call to gnome_metadata_get may make Nautilus do excessive I/O, but that'
s
an issue for another time.

You can actually lock the metadata database yourself before any
metadata operations, do all your reads and unlock it to avoid this.

GMC does that for its desktop directory I believe.

Your patch to Nautilus sprinkled gnome_metadata_get calls in various places. I'm not sure where to put the lock and unlock calls.

I think the structure of Nautilus may be unusual enough that it's hard to get this aspect right. But I'll look into it eventually.

    -- Darin




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]