Re: [PATCH to panel] popup menu and "run" dialog independant of the state of ScrollLock and NumLock

Vlad Harchev <hvv hippo ru> writes:
> +	
> +	ignored_mods = ~(GDK_LOCK_MASK /*capslock*/ | GDK_MOD2_MASK /*numlk*/ | 
> +		GDK_MOD5_MASK /*scrolllock*/| 0x2000 /*Xkb modifier*/);

That isn't right, there's no guarantee or even likelihood that MOD2
and MOD5 will have those mappings. They might be used for
super/hyper/etc. which would be legitimate keys to use for the

Instead of ignoring some mods, the patch should see if the expected
mods are set. i.e. if ((keypress_state & binding_mods) == binding_mods).


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]