Re: glimmer showing untagged text

[Jeroen Zwartepoorte <jeroen xs4all nl>]

Aarrgh. I shouldn't get out of bed this early.

Michael: it works fine, i just applied the patch incorrectly (again).
I've verified that it works fine now. I'll commit it shortly.

Thanks,

Jeroen

On Thu, 2002-12-19 at 08:48, Jeroen Zwartepoorte wrote:
> Hmm, I applied the patch incorrectly. But after fixing that, the colors
> are still not what they should: with the default theme, whitespace is
> black (should be white like the rest). I'll take a look at the code
> myself.
> 
> Jeroen
> 
> On Thu, 2002-12-19 at 08:37, Jeroen Zwartepoorte wrote:
> > Hi Michael,
> > 
> > On Wed, 2002-12-18 at 15:13, Michael Karcher wrote:
> > > On Mon, Dec 09, 2002 at 09:06:48AM +0100, Jeroen Zwartepoorte wrote:
> > > [White space should be plain text, and foreground color should be used]
> > > > Yep. It's a bug. When i wrote the theming support i was short on time
> > > > and didn't fix that before committing. Shouldn't be too hard to fix
> > > > though. Patches are more than welcome :-)
> > > 
> > > Look three lines below. :-)
> > > Michael Karcher
> > 
> > Thanks for the patch. Some comments below:
> > 
> > > diff -urN glimmer-pristine/libglimmerfile/glimmer-style-cache/themes/default.xml glimmer/libglimmerfile/glimmer-style-cache/themes/default.xml
> > > --- glimmer-pristine/libglimmerfile/glimmer-style-cache/themes/default.xml	Tue Jul 16 23:47:33 2002
> > > +++ glimmer/libglimmerfile/glimmer-style-cache/themes/default.xml	Mon Dec 16 14:11:19 2002
> > > @@ -102,10 +102,10 @@
> > >  		<background>0xFFFFFF</background>
> > >  		<foreground>0x00CF00</foreground>
> > >  	</style>
> > > -	<style name="whitespace">
> > > +	<style name="plain-text">
> > >  		<bold>false</bold>
> > >  		<italic>false</italic>
> > >  		<background>0xFFFFFF</background>
> > > -		<foreground>0xFFFFFF</foreground>
> > > +		<foreground>0x000000</foreground>
> > 
> > Why this change? With this change, glimmer comes up with just a black
> > rectangle (foreground is black). In the classic theme it's black as
> > well.
> > 
> > With this patch, the problem of "black on blue" for untagged text still
> > exists afaict.
> > 
> > Jeroen
> > 
> > _______________________________________________
> > gnome-devtools mailing list
> > gnome-devtools gnome org
> > http://mail.gnome.org/mailman/listinfo/gnome-devtools
-- 
Jeroen Zwartepoorte <jeroen xs4all nl>