Re: gtksourceview requires libgnome

[Gustavo Giráldez <gustavo giraldez gmx net>]

Hi Michael,

On Mon, 2003-05-12 at 19:55, Michael Terry wrote:
> This one feels good.  :)

Close, but not yet ;-)

a) The parent type of GtkSourceTagTable is GtkTextTagTable, not
GObject.  So when you call g_type_register_static () in
gtksourcetagtable.c, the first argument should be
GTK_TYPE_TEXT_TAG_TABLE instead of G_TYPE_OBJECT.  I hadn't noticed this
one until now (it causes a lot of warnings on the console btw).

b) Your patch didn't apply cleanly.  I made two commits today, and so
the ChangeLog hunk failed.  Please cvs update and fix the conflict.

Otherwise looks great.  Please commit after you've fixed both issues. 
Remember to cvs update first.

Thanks,
Gustavo