Re: Evolution contact editor title changes

[danilo gnome org (Danilo Šegan)]

Today at 18:44, Shaun McCance wrote:

> Does the i18n team know about this?  They're usually not too
> fond of forming strings by concatenation.

Now we know about it :)

> For the non-patch readers in the audience, the window's title
> is constructed like this:
>
> g_strconcat (_("Contact Editor"), " - ", string, NULL);
>
> Wouldn't a format string be more appropriate, like so:
>
> g_strdup_printf (_("Contact Editor - %s", string));

Exactly, that's way better.  If you want to save yourself from a bug
report later, you don't want to use g_strconcat in this way. 

Cheers,
Danilo