Re: GNOME_COMPILE_WARNINGS() not doing good.

[German Poo Caaman~o <gpoo ubiobio cl>]

El jue, 17-01-2002 a las 13:42, Owen Taylor escribió:
> ===================================================================
> RCS file: /cvs/gnome/gnome-core/configure.in,v
> retrieving revision 1.352
> diff -u -p -r1.352 configure.in
> --- configure.in	2002/01/16 11:33:01	1.352
> +++ configure.in	2002/01/17 16:39:32
> @@ -1,7 +1,11 @@
>  AC_PREREQ(2.13)
>  
> +# Save this value here, since CFLAGS will be set _always_ further down
> +cflags_set=${CFLAGS+set}
> +
>  AC_INIT(panel)
>  AM_CONFIG_HEADER(config.h)
> +
>  AM_INIT_AUTOMAKE(gnome-core, 1.5.4)
>  
>  AM_MAINTAINER_MODE
> @@ -28,6 +32,9 @@ dnl ====================================
>  
>  GNOME_PLATFORM_GNOME_2(yes)
>  GNOME_COMPILE_WARNINGS(maximum)
> +if test x$cflags_set != xset ; then
> +  CFLAGS="$CFLAGS $WARN_CFLAGS"
> +fi

I forgot it, except of 'make distcheck', WARN_CFLAGS will be set
as the same as GNOME_COMPILE_WARNINGS(yes), not
GNOME_COMPILE_WARNINGS(maximum).

Easy to check.  In your log or Makefile, you'll see:

-Wall -Wunused -Wmissing-prototypes -Wmissing-declarations

instead:
-Wall -Wunused -Wchar-subscripts -Wmissing-declarations
-Wmissing-prototypes -Wnested-externs -Wpointer-arith

as gnome2-macros/compiler-flags.m4 says.

-- 
German Poo Caaman~o
mailto:gpoo ubiobio cl
http://www.ubiobio.cl/~gpoo/chilelindo.html