Re: intltool and glib-gettextize



On Sun, 2001-10-28 at 13:06, Darin Adler wrote:
> on 10/28/01 8:59 AM, jacob berkman at jacob@ximian.com wrote:
> 
> > this patch adds support for po/Makefile.in.in installed by
> > glib-gettextize.
> 
> Looks OK to me; I have only a few minor reservations, none of which should
> prevent you from committing:
> 
>     1) A bit strange to have to patch the Makefile.in.in from the glib
> gettextize. The reason we had to do it in the case of gettext was that we
> had no influence with the gettext maintainers, so no way to get the hook in
> that we needed.

doing anything else adds a pseudo dependency to glib on intltool.  i
didn't feel so clean adding this.

>     2) I don't know why the patch adds a definition for top_builddir.
> 
>     3) I don't know why the patch adds a ".po: Makefile" rule.

becuase the other patches did.  i'll remove the top_builddir one as it
doesn't get used anywhere.

jacob
-- 
"Beat mixing is 10000 times more fun than even video games."
	-- bt



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]