Re: [G2R] Translation of .schemas files in core modules

[Kjartan Maraas <kmaraas online no>]

ons, 2002-07-31 kl. 13:29 skrev Kjartan Maraas:
> ons, 2002-07-31 kl. 11:05 skrev Zbigniew Chyla:
> > On Wed, 2002-07-31 at 09:30:07, Kjartan Maraas wrote:
> > 
> > > -	uiinfo->widget = gtk_image_menu_item_new_with_mnemonic (L_("_Contents"));
> > > +	title = g_strdup (_("_Contents"));	
> > > +	uiinfo->widget = gtk_image_menu_item_new_with_mnemonic (L_(title));
> > > +	g_free(title);
> > 
> > This is wrong.
> > You're trying to translate already translated string. Calling
> > gettext (gettext (title)) may return an invalid string (in theory).
> > Besides, you don't need g_strdup/g_free here.
> 
> So how do we fix this without the L_(N_()) hack? Have you actually
> tested to see if it works at all?
> 
> At least this way it worked when I tested it.
> 

/me kicks self for sounding so grumpy. That's what two hours of sleep
does to you :)

Better solutions are welcome and I think they have to surface quickly if
they are to be in the 2.0.1 release.

Cheers
Kjartan