Re: [i18n] Looking for inconsistencies

[Thierry Vignaud <tvignaud mandrakesoft com>]

Arkadiusz Lipiec <A.Lipiec@elka.pw.edu.pl> writes:

> 2. Harddrake2 - "Click on a device in the left tree in order to
> display its information here." - this entry isn't translated in any
> language.

yes, it got broken in r1.28 by pablo:
Index: standalone/harddrake2
===================================================================
RCS file: /cooker/gi/perl-install/standalone/harddrake2,v
retrieving revision 1.27
retrieving revision 1.28
diff -u -p -r1.27 -r1.28
--- standalone/harddrake2	16 Jan 2003 15:03:23 -0000	1.27
+++ standalone/harddrake2	24 Jan 2003 09:11:31 -0000	1.28
@@ -20,10 +20,10 @@ my %fields = 
      [ N("Bus"), 
        N("this is the physical bus on which the device is plugged (eg: PCI, USB, ...)") ],
      "channel" => [ N("Channel"), N("EIDE/SCSI channel") ],
-     "bogomips" => [ N("Bogomips"), N("The GNU/Linux kernel needs to do run a calculation loop at boot time to initialize a timer counter.  Its result is stored as bogomips as a way to \"benchmark\" the cpu.") ],
+     "bogomips" => [ N("Bogomips"), N("The GNU/Linux kernel needs to run a calculation loop at boot time to initialize a timer counter.  Its result is stored as bogomips as a way to \"benchmark\" the cpu.") ],
      "bus_id" => 
      [ N("Bus identification"), 
-       N("- PCI and USB devices: this list the vendor, device, subvendor and subdevice PCI/USB ids") ],
+       N("- PCI and USB devices: this lists the vendor, device, subvendor and subdevice PCI/USB ids") ],
      "bus_location" => 
      [ N("Location on the bus"), 
        N("- pci devices: this gives the PCI slot, device and function of this card
@@ -38,16 +38,16 @@ my %fields = 
      "device" => [ N("Old device file"),
                    N("old static device name used in dev package") ],
      "devfs_device" => [ N("New devfs device"),  
-                         N("new dinamic device name generated by incore kernel devfs") ],
-     "driver" => [ N("Module"), N("the module of the GNU/Linux kernel that handle that device") ],
+                         N("new dinamic device name generated by core kernel devfs") ],
+     "driver" => [ N("Module"), N("the module of the GNU/Linux kernel that handles the device") ],
      "flags" => [ N("Flags"), N("CPU flags reported by the kernel") ],
      "fdiv_bug" => [ N("Fdiv bug"), 
-                     N("Early Intel Pentium chips manufactured have a bug in their floating point processor which did not achieve the attended precision when performing a Floating point DIVision (FDIV)") ],
+                     N("Early Intel Pentium chips manufactured have a bug in their floating point processor which did not achieve the required precision when performing a Floating point DIVision (FDIV)") ],
 
 
      "fpu" => [ N("Is FPU present"), N("yes means the processor has an arithmetic coprocessor") ],
      "fpu_exception" => [ N("Whether the FPU has an irq vector"), N("yes means the arithmetic coprocessor has an exception vector attached") ],
-     "f00f_bug" => [N("F00f bug"), N("Early pentium were buggy and freezed when decoding the F00F bytecode")],
+     "f00f_bug" => [N("F00f bug"), N("Early pentiums were buggy and freezed when decoding the F00F bytecode")],
      "hlt_bug" => [ N("Halt bug"), 
                     N("Some of the early i486DX-100 chips cannot reliably return to operating mode after the \"halt\" instruction is used") ],
 
@@ -94,7 +94,7 @@ my @menu_items = 
                                N("Description of the fields:\n\n")
                                . join("\n\n", map { if_($fields{$_}[0], "$fields{$_}[0]: $fields{$_}[1]") } sort keys %$current_device))
                  } else {
-                     $in->ask_warn(N("Select a device !"), N("Once you've selected a device, you'll be able to see explanations on fields displayed on the right frame (\"Information\")"))
+                     $in->ask_warn(N("Select a device !"), N("Once you've selected a device, you'll be able to see the device information in fields displayed on the right frame (\"Information\")"))
                  }
              }
      },
@@ -190,7 +190,7 @@ my $selection = gtksignal_connect($tree-
             return 1;
         }
     }
-    $text->get_buffer->set_text(N_("Click on a device in the left tree in order to get its information displayed here."), -1);
+    $text->get_buffer->set_text(N_("Click on a device in the left tree in order to display its information here."), -1);
     $config_button->hide;
     $module_cfg_button->hide;
 });

here's the fix:
Index: standalone/harddrake2
===================================================================
RCS file: /cooker/gi/perl-install/standalone/harddrake2,v
retrieving revision 1.67
diff -u -p -r1.67 harddrake2
--- standalone/harddrake2	1 Apr 2003 13:28:23 -0000	1.67
+++ standalone/harddrake2	2 Apr 2003 13:59:33 -0000
@@ -231,7 +231,7 @@ $tree->get_selection()->signal_connect('
             return 1;
         }
     }
-    $text->get_buffer->set_text(N_("Click on a device in the left tree in order to display its information here."), -1);
+    $text->get_buffer->set_text(N("Click on a device in the left tree in order to display its information here."), -1);
     $config_button->hide;
     $module_cfg_button->hide;
 });
@@ -297,7 +297,7 @@ foreach (@harddrake::data::tree) {
         push @data, $_;
         push @configurators, $configurator;
     }
-    $tree->expand_row($tree_model->get_path($parent_iter), 1) unless $title eq N_("Unknown/Others");
+    $tree->expand_row($tree_model->get_path($parent_iter), 1) unless $title eq N("Unknown/Others");
     $parent_iter->free;
 }
 

pablo, why do you changed these two N() into N_() ?

> 4. Most services' descriptions are not translatable (after clicking
> information button)

we've to handly add them to description() in services.pm