Re: string addition

[murrayc t-online de (Murray Cumming)]

If you're asking for release-team approval then you really should give
us more information. We usually like to hear at least:
1. What does it do?
2. What's the advantage of the change?
3. Why would it be bad to wait for 2.4?

On Thu, 2003-01-02 at 18:41, Havoc Pennington wrote:
> Hi,
> 
> I think this might be a good idea, opinions?
> 
> Havoc
> 
> 
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/gnome-terminal/ChangeLog,v
> retrieving revision 1.263
> diff -u -p -u -r1.263 ChangeLog
> --- ChangeLog   22 Dec 2002 17:26:04 -0000      1.263
> +++ ChangeLog   2 Jan 2003 17:40:26 -0000
> @@ -1,3 +1,7 @@
> +2003-01-02  Havoc Pennington  <hp@redhat.com>
> +
> +       * src/encoding.c: add ISO-8859-2
> +
>  2002-12-22  Christian Neumair  <chris@gnome-de.org>
>                                                                                 
>         * src/terminal-window.c: Revamped about dialog (#101812).
> Index: src/encoding.c
> ===================================================================
> RCS file: /cvs/gnome/gnome-terminal/src/encoding.c,v
> retrieving revision 1.6
> diff -u -p -u -r1.6 encoding.c
> --- src/encoding.c      8 Dec 2002 05:00:24 -0000       1.6
> +++ src/encoding.c      2 Jan 2003 17:40:26 -0000
> @@ -58,6 +58,8 @@ static TerminalEncoding encodings[] = {
>                                                                                 
>    { TERMINAL_ENCODING_ISO_8859_1, FALSE,
>      "ISO-8859-1", N_("Western") },
> +  { TERMINAL_ENCODING_ISO_8859_2, FALSE,
> +    "ISO-8859-2", N_("Central European") },
>    { TERMINAL_ENCODING_ISO_8859_3, FALSE,
>      "ISO-8859-3", N_("South European") },
>    { TERMINAL_ENCODING_ISO_8859_4, FALSE,
> _______________________________________________
> release-team mailing list
> release-team@gnome.org
> http://mail.gnome.org/mailman/listinfo/release-team
-- 
Murray Cumming
murray@usa.net
www.murrayc.com