Re: Request for approval of string addition in gpdf

[Christian Rose <menthos gnome org>]

tor 2004-08-19 klockan 23.35 skrev Martin Kretzschmar:
> I'd like to apply this patch to gpdf. It fixes a crasher bug but adds a
> string.
> 
> http://bugzilla.gnome.org/show_bug.cgi?id=150476
> 
> The problem with the current code can be seen in the last line of the
> context in the patch: If app is NULL, reading app->name segfaults.
> 
> The same problem makes it impossible to reuse the already present format
> string in the line above: If we don't have app->name, there's nothing to
> use for the first %s. I can't see a way to fix this without adding a
> string.
> 
> Can we add this string?

Sounds like there is no way around it, and it fixes an important bug, so
you definately have my approval.
Please let gnome-i18n gnome org know when this has been fixed in CVS and
it's time to update translations.


Thanks,
Christian