Re: libgnomeui broke the string freeze



hej,

Am Sonntag, den 03.09.2006, 20:56 -0400 schrieb Matthias Clasen:
> On 9/3/06, Christian Rose <menthos gnome org> wrote:
> > On 9/2/06, Wouter Bolsterlee <uws+gnome xs4all nl> wrote:
> > > The libgnomeui commit [1] by Kristian Rietveld introduced a new string [2],
> > > which is unacceptable in string freeze, 4 days before a release. There has
> > > not been any notification sent out to to gnome-i18n either...
> > >
> > > Please revert the patch or make sure you reuse an already existing string.
> > >
> > >   thanks, Wouter
> > >
> > > [1] http://cvs.gnome.org/viewcvs/libgnomeui/file-chooser/gtkfilesystemgnomevfs.c?r1=1.80&r2=1.81
> > > [2] "Error getting information for '%s'"
> >
> > Indeed, this is not acceptable. Kris, could you please revert this
> > string addition?
> 
> Reverting the patch would give you a gnome release with a very broken
> filechooser. Do you really want that ?

assuming that the patch fixed
http://bugzilla.gnome.org/show_bug.cgi?id=352686 , i definitely do not
want to see the patch reverted in its entirety.

> And removing the _() just for formal string freeze reasons would be a
> bit silly, since the end effect would be just the same, an
> untranslated error message...

in order to not break the string freeze, a (rather stupid?) workaround
would be to use an already existing libgnomeui error message like either
* msgid "Error reading file '%s': %s"
* msgid "Error cannot find file id '%s'"
* msgid "Error"
(all three strings copied from the .po file)

cheers,
andre

-- 
 mailto:ak-47 gmx net | failed!
 http://www.iomc.de

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]