Re: String additions to 'gnome-panel.HEAD'

[Claude Paroz <claude 2xlibre net>]

Le mardi 19 février 2008 à 10:41 -0500, Matthias Clasen a écrit :
> On Tue, 2008-02-19 at 16:34 +0100, Andre Klapper wrote:
> > Am Dienstag, den 19.02.2008, 08:49 -0500 schrieb Matthias Clasen:
> > > On Tue, 2008-02-19 at 09:08 +0100, Claude Paroz wrote:
> > > Please, revert the commit and wait until you get two approvals for your
> > > > request from gnome-i18n Team before committing the patch. Thanks!
> > 
> > > No. 
> > > 
> > > See, this is not a random unmotivated string change that I did to annoy
> > > the translators. This is a serious bugfix that happens to require a few
> > > new strings, which don't even cause any problems when left untranslated.
> > 
> > hi matthias,
> > 
> > things would be easier if you'd just come up with a short bug
> > description or a bugzilla link. i know that the clock has some urgent
> > bugs to fix for 2.22, but being unfriendly towards the translator does
> > not help anybody.
> 
> Gosh, don't we have more important things to do than fight over 4 (!)
> irrelevant strings ? Here is what I sent to Vincent about the patches.
> Last mail from me on this topic. 
> 
> 
> Matthias
> 
> 
> 
> Here is a bunch of post-merge fixes that I worked on this weekend.
> Sending mail first instead of committing right away, since some of them
> are somewhat more invasive, so I'd rather get a second pair of eyes.
> Or, if you don't care, just tell me to go ahead...
> 
> localtime.patch: This fixes the time display in the location tiles to be
> the time at the location (currently, all tiles show the local time,
> which is rather pointless). The also involved changing the interaction
> between ClockLocationTile and Clock somewhat. Instead of the
> need-formatted-time signal, there is now a need-clock-format signal,
> since the tiles really only want to adapt to the 12/24h preference, and
> do their own time formatting otherwise. This currently introduces some
> new strings (the strftime formats used for formatting the time for the
> tiles), but we could easily leave them untranslated for now to keep
> string freeze.
> 
> pref-dialogs.patch: makes all of the nested pref dialogs use the dialog
> window class, to avoid some focus and stacking order oddities with
> metacity.
> 
> set-button.patch: Makes the "Set" button on the location tiles work.
> 
> panel-weather.patch: Fixes the display of the weather on the panel. This
> also fixes some memory management errors wrt to ClockData.locations, and
> changes the interaction between Clock and ClockLocationTile by making
> the clock listen to weather updates directly on the ClockLocation
> instead of proxying that signal through ClockLocationTile. This is
> necessary since the tiles are not constructed until you pop up the
> calendar for the first time, so you would not get weather on the panel
> before that...
> 
> 
> async-timezone.patch: make the timezone setting async, so that the clock
> keeps ticking while the auth dialog is up.

Thanks for the details. 1 of 2 approvals from me, but please, PLEASE,
next time wait for the approvals before comitting.
We need rules to make the GNOME community rock! Even if it seems
sometimes limiting.

Keep the good work.

Claude