Totem string freeze break request



Hi,

After talking to Bastien about the (now reverted) accidental freeze
break in revision 5187, we've decided to ask for a proper freeze break
for it.

http://bugzilla.gnome.org/show_bug.cgi?id=454642

We're requesting addition of one string ("Time seek bar") to add an
accessibility label to the seek bar --- an important part of Totem.

The same label used to be in Totem before we switched to GtkBuilder, but
was lost when converting the glade files; there's the possibility that
some of the .po files still have commented-out translations of the
string, if that helps. (From a quick grep, maybe 20 have it present but
commented out.)

The patch itself has been tested, and carries minimal risk. This would
stop Totem's usability regressing due to the GtkBuilder conversion, and
as such we think it's an important change.

The patch is attached.

Regards,
Philip
Index: totem.ui
===================================================================
--- totem.ui	(revision 5190)
+++ totem.ui	(working copy)
@@ -2137,6 +2137,11 @@
 			  <signal name="button-press-event" handler="seek_slider_pressed_cb"/>
 			  <signal name="button-release-event" handler="seek_slider_released_cb"/>
 			  <signal name="scroll-event" handler="window_scroll_event_cb"/>
+			  <child internal-child="accessible">
+                            <object class="AtkObject" id="a11y-tmw_seek_hscale">
+                              <property name="AtkObject::accessible-name" translatable="yes">Time seek bar</property>
+                            </object>
+                          </child>
 			  <accessibility>
 			    <relation target="tmw_time_label" type="labelled-by"/>
 			  </accessibility>

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]