[CC: gnome-i18n]
Hi Matthias,
See below.
2009-01-21 klockan 21:09 skrev matthiasc svn gnome org:
> Modified: trunk/gtk/gtkentry.c
> ==============================================================================
> --- trunk/gtk/gtkentry.c (original)
> +++ trunk/gtk/gtkentry.c Wed Jan 21 20:09:49 2009
> @@ -9598,17 +9597,8 @@
>
> if (!entry->visible && priv->caps_lock_warning)
> {
> - gboolean capslock_on;
> - gboolean im_on;
> -
> - capslock_on = gdk_keymap_get_caps_lock_state (keymap);
> - im_on = g_strcmp0 (gtk_im_multicontext_get_context_id (GTK_IM_MULTICONTEXT (entry->im_context)), "gtk-im-context-simple") != 0;
> - if (capslock_on && im_on)
> - text = _("You have the Caps Lock key on\nand an active input method");
> - else if (capslock_on)
> + if (gdk_keymap_get_caps_lock_state (keymap))
> text = _("You have the Caps Lock key on");
> - else if (im_on)
> - text = _("You have an active input method");
> }
Can this string perhaps be changed to not address users directly by avoiding
"you"? This sounds unfriendly to unknowing users (what did I do wrong?), and
is even considered bad form in some cultures. Furthermore, a caps lock key
cannot be "on": either *caps lock* is on, or the *caps lock key* has been
pressed. Suggested string change: "Caps Lock is on."
— Wouter
Attachment:
signature.asc
Description: Digital signature