Re: String freeze break in gnome-disk-utility

[David Zeuthen <davidz redhat com>]

On Mon, 2010-03-15 at 16:25 +0100, Claude Paroz wrote:
> > OK, can I get an approval please? This is about the string "%s File". An
> > appropriate translator comment would look like this.
> > 
> >  /* Translators: This is the name of a "Drive" backed by a file.
> >   * The %s is the size of the file (e.g. "42 GB" or "5 KB").
> >   */
> >  g_string_append_printf (result, "%s File", strsize);
> 
> As we are closed to the release, I think you should tell us why this is
> critical.
> If this was not a bug, I suggest to postpone it for the .1 release. What
> do you (or others) think?

I added this string because udisks starting exposing loop devices and
without this change the UI would say "10 GB Hard Disk" for loop
devices... and this is a lot worse than saying "10 GB File" even if it's
not translated. As such, I don't think it is wise to post-pone this
change. Normally, users will never deal with loop devices so it's not
like it's affecting a lot of users.

Thanks,
David