Re: Mnemonic update for Epiphany question/request

[Diego Escalante Urrelo <diegoe gnome org>]

Nope, that's ok. Thanks :)

On Sun, Mar 4, 2012 at 5:01 PM, Jiro Matsuzawa <jmatsuzawa src gnome org> wrote:
> I've just pushed.
> http://git.gnome.org/browse/epiphany/commit/?id=09b5484d8f321ad2f53bbc82f49233bfaac043e9
>
> If I need to revert it, please let me know.
> Thank you,
>
>
> On Sun, Mar 4, 2012 at 1:59 AM, Jiro Matsuzawa <jmatsuzawa src gnome org> wrote:
>> Hi Diego,
>>
>> I am the author of the patch and a Japanese translator.
>> I didn't notice the status changed to "accepted-commit_now".
>> The patch is trivial, so it will have little affect on translators.
>> And the module has not been string-frozen yet.
>> It should be good to push it.
>>
>> Thank you.
>>
>>
>> On Sat, Mar 3, 2012 at 2:38 PM, Diego Escalante Urrelo <diegoe gnome org> wrote:
>>> Hi,
>>>
>>> we received this contribution:
>>>  https://bugzilla.gnome.org/show_bug.cgi?id=670328
>>>
>>> it is just an update to make "Create" have a mnemonic as "C_reate".
>>>
>>> Is it ok to push this, or not worth the translation breakage?
>>> I am not aware how much of a big deal this would be for translators,
>>> so better to ask.
>>>
>>>
>>> Diego
>>>
>>>
>>> -8<----
>>> Inline patch:
>>>
>>> commit 8d70f71a8d0da7518c4b4a6f533fbdf356c489b8
>>> Author: Jiro Matsuzawa <jmatsuzawa src gnome org>
>>> Date:   Sat Feb 18 12:58:54 2012 +0900
>>>
>>>    window-commands: enable mnemonic for Create button
>>>
>>>    I use 'r' of "Create" as a mnemonic character because "C" is
>>>    already used by "_Cancel".
>>>
>>>    https://bugzilla.gnome.org/show_bug.cgi?id=670328
>>>
>>>    Signed-off-by: Diego Escalante Urrelo <diegoe igalia com>
>>>
>>> diff --git a/src/window-commands.c b/src/window-commands.c
>>> index 0189b85..b493a39 100644
>>> --- a/src/window-commands.c
>>> +++ b/src/window-commands.c
>>> @@ -576,7 +576,7 @@ window_cmd_file_save_as_application (GtkAction *action,
>>>                                              0,
>>>                                              GTK_STOCK_CANCEL,
>>>                                              GTK_RESPONSE_CANCEL,
>>> -                                             _("Create"),
>>> +                                             _("C_reate"),
>>>                                              GTK_RESPONSE_OK,
>>>                                              NULL);
>>> _______________________________________________
>>> gnome-i18n mailing list
>>> gnome-i18n gnome org
>>> http://mail.gnome.org/mailman/listinfo/gnome-i18n
>>
>>
>>
>> --
>> Jiro Matsuzawa
>> E-mail:
>>   jmatsuzawa src gnome org
>>   matsuzawa jr gmail com
>> GPG Key ID: 0xECC442E9
>> GPG Key Fingerprint: E086 C14A 869F BB0E 3541 19EB E370 B08B ECC4 42E9
>
>
>
> --
> Jiro Matsuzawa
> E-mail:
>   jmatsuzawa src gnome org
>   matsuzawa jr gmail com
> GPG Key ID: 0xECC442E9
> GPG Key Fingerprint: E086 C14A 869F BB0E 3541 19EB E370 B08B ECC4 42E9