Re: Freeze exception request



o/

On Thu, Sep 29, 2016, at 08:01 AM, Michael Catanzaro wrote:
+  <schema id="org.gnome.Epiphany.host" gettext-domain="">
+    <key name="notifications-permission"
enum="org.gnome.Epiphany.host.permissions">
+      <default>"undecided"</default>
+    </key>
+  </schema>
+</schemalist>

Gustavo, where are the descriptions of the new settings? :-)

So you have inadventantly not broken string freeze. This patch doesn't
require approval for gnome-3-22, then. But please, add descriptions for
the settings on master.

Erm… yes, I forgot to write the descriptions back when I wrote the patch
originally. But there are strings in this patch anyway, because of the
nicks:

+  <enum id="org.gnome.Epiphany.host.permissions">
+    <value nick="undecided" value="-1"/>
+    <value nick="deny" value="0"/>
+    <value nick="allow" value="1"/>
+  </enum>

Whether that requires a freeze exception I do not know =). Will add
descriptions to master.

Cheers,

Gustavo Noronha


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]