Re: Wrong context in 2 strings

[Jehan Pagès <jehan marmottard gmail com>]

Ok thanks everyone for the quick answers.

Seeing the unanimous (well up to now) answer, I just committed and pushed the quick fix.

Commits 7a5e5be35e9b20e494767726fc58216c74125a08 on master and 66803bc2b3705830cf2f262fdd42e994aa990008 on gimp-2-10 branch.

As for future events, I guess I'll use my best judgement, and (if such things ever happen again) if really I see that's the same thing (no actual context/usage change, just an error in the msgctxt), I guess I would just push.

But I'll ask again the question if I have any doubt or if the issue is slightly different. :-)

Thanks again.

Jehan

On Thu, Feb 7, 2019 at 5:32 PM Kolbjørn Stuestøl <kolbjoern stuestoel no> wrote:

Thank you for doing this this time and in the future for Norwegian nynorsk (language code nn).
Kolbjørn

Den 07.02.2019 17:17, skreiv Daniel Mustieles García via gnome-i18n:

It is because of changing message context will cause DL to mark that string as fuzzy. This is why he is asking to apply the change directly into the PO files. These PO should be modified by developers, but in this case it is harmless because translated strings are not affected ;-)

Cheers!

El jue., 7 feb. 2019 a las 16:44, Snehalata Shirude via gnome-i18n (<gnome-i18n gnome org>) escribió:

Hi,

If the meaning does not change, i think it can be directly changed using find and replace. So it should not be directly related to the translation process as such. 

Thanks

Snehalata Shirude

Translator, for Marathi, 

India

On Thu 7 Feb, 2019, 8:42 PM Jehan Pagès via gnome-i18n, <gnome-i18n gnome org> wrote:

Hi!

In GIMP, we had a small bug in 2 strings: "Grow lighter areas of the image" and "Grow darker areas of the image".

Basically in our code, we declared the strings with "drawable-action" context (hence that was the msgctx registered in po files) but called the translation with "filters-action" context so they were not translated.

I fixed the code to use "filters-action" everywhere (the other was wrong), but the wrong context is now in various po/*.po files (43 files).

Do you mind if I just do a massive search-and-replace for these 2 context/strings to fix them? I mean, I actually already did it locally (took 20 secs), and I think that it is simpler than having everyone just edit manually for what was basically just a code bug. The actual context is the same (these strings are filter descriptions, same place in the GUI as what they were, nothing changed GUI-wise). So that looks harmless to me.

Yet I have been told we should not touch the po files ourselves, if possible.

So 2 questions:

1/ Is it ok if I just push this change?

2/ In the future, what should be our process as developers when we just see these kinds of code issues affecting the po files? Can we just push (making our own decision that this is not a translation issue) or we must ask case by case?

Thanks for the awesome work, all!

Jehan

--

ZeMarmot open animation film
http://film.zemarmot.net
Liberapay: https://liberapay.com/ZeMarmot/
Patreon: https://patreon.com/zemarmot
Tipeee: https://www.tipeee.com/zemarmot

_______________________________________________
gnome-i18n mailing list
gnome-i18n gnome org
https://mail.gnome.org/mailman/listinfo/gnome-i18n

_______________________________________________
gnome-i18n mailing list
gnome-i18n gnome org
https://mail.gnome.org/mailman/listinfo/gnome-i18n

_______________________________________________
gnome-i18n mailing list
gnome-i18n gnome org
https://mail.gnome.org/mailman/listinfo/gnome-i18n

Virusfri. www.avast.com

_______________________________________________
gnome-i18n mailing list
gnome-i18n gnome org
https://mail.gnome.org/mailman/listinfo/gnome-i18n

--

ZeMarmot open animation film
http://film.zemarmot.net
Liberapay: https://liberapay.com/ZeMarmot/
Patreon: https://patreon.com/zemarmot
Tipeee: https://www.tipeee.com/zemarmot