[RFC] Distinguish locales with modifiers



Hi all!

My first message to this list. Sorry for being somewhat wordy.

Some locales have modifiers appended to them. Examples:

ca_ES@valencia
sr_RS@latin

Currently, in the Language and Formats views in gnome-control-center, such locales are shown with the same labels as their equivalents without modifiers. So in the Language view you may see two occurrences of:

Catalan                    Spain

and

Serbian                    Serbia

and in the Formats view you may see two occurrences of:

Spain (Catalan)

and

Serbia (Serbian)

The issue has been reported here:

https://gitlab.gnome.org/GNOME/gnome-desktop/issues/50

and is about to be fixed now. Already committed changes together with proposed changes to gnome-desktop and gnome-control-center result in this:

Language view
-------------
Catalan                    Spain
Catalan — Valencia         Spain

Serbian                    Serbia
Serbian — Latin            Serbia

Formats view
------------
Spain (Catalan — Valencia)
Spain (Catalan)

Serbia (Serbian — Latin)
Serbia (Serbian)

The key to achieve this is the function gnome_get_translated_modifier() in this file:

https://gitlab.gnome.org/GNOME/gnome-desktop/blob/master/libgnome-desktop/gnome-languages.c

where a few translatable strings, representing raw modifier strings, have been hard coded.

I'm bringing this to your attention to ask if you think the solution in the making is reasonable and something you feel comfortable with. If you have doubts, please respond to this message or comment on the still open merge request:

https://gitlab.gnome.org/GNOME/gnome-desktop/merge_requests/45

Thanks!

--
Gunnar Hjalmarsson
https://launchpad.net/~gunnarhj


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]