Re: Build error

[Rafael Fontenelle <rafaelff gnome org>]

Awesome, thanks Daniel and Claude for making our translation platform better.

Em qua., 11 de mar. de 2020 às 10:25, Daniel Mustieles García via
gnome-i18n <gnome-i18n gnome org> escreveu:
> Great, thanks!
>
> El mié., 11 mar. 2020 a las 14:20, Claude Paroz (<claude 2xlibre net>) escribió:
> > Should be OK now, thanks for re-applying.
> >
> > Claude
> >
> > Le 11.03.20 à 08:48, Daniel Mustieles García a écrit :
> > > Sure, I've reverted the commit I did, so LINGUAS is again called from
> > > Makefile.
> > >
> > > Thanks Claude!
> > >
> > > El mié., 11 mar. 2020 a las 8:30, Claude Paroz (<claude 2xlibre net
> > > <mailto:claude 2xlibre net>>) escribió:
> > >
> > >     I'm sorry, I didn't check if the LINGUAS thing was working for
> > >     release-notes. I would have fixed D-L if I had known.
> > >
> > >     Maybe you could re-apply the LINGUAS patch and I'll fix D-L ASAP. Just
> > >     tell me.
> > >
> > >     Claude
> > >
> > >     Le 11.03.20 à 08:21, Daniel Mustieles García via gnome-i18n a écrit :
> > >     > We can watch it and add new languages to Makefile if they are
> > >     added into
> > >     > DL, there is no problem with it.
> > >     >
> > >     > About DL, yes, it would be great if it would allow doing things
> > >     like you
> > >     > did, but it doesn't. The best option would be adding new languages
> > >     > automagically to Makefile, but it was difficult to implement properly
> > >     >
> > >     > El mar., 10 mar. 2020 a las 23:00, Rafael Fontenelle
> > >     > (<rafaelff gnome org <mailto:rafaelff gnome org>
> > >     <mailto:rafaelff gnome org <mailto:rafaelff gnome org>>>) escribió:
> > >     >
> > >     >     Hi Daniel,
> > >     >
> > >     >     I notice the warning, but I'm afraid that D-L might allow
> > >     adding new
> > >     >     translation to Release Notes by adding it to the LINGUAS file, and
> > >     >     right now Release Notes does not read the LINGUAS file.  Don't you
> > >     >     think this can be a problem like translation being added but not
> > >     >     effectively enabled?
> > >     >
> > >     >     Em ter., 10 de mar. de 2020 às 18:55, Daniel Mustieles García
> > >     >     <daniel mustieles gmail com
> > >     <mailto:daniel mustieles gmail com>
> > >     <mailto:daniel mustieles gmail com <mailto:daniel mustieles gmail com>>>
> > >     >     escreveu:
> > >     >     >
> > >     >     > Hi Rafael,
> > >     >     >
> > >     >     > I've done it because DL was not able to read languages variable
> > >     >     from the Makefile, showing warnings in every language shown in DL
> > >     >     for release-notes module.
> > >     >     >
> > >     >     > I know adding languages manually to Makefile is not the best
> > >     >     option, but that's the way it's done in other modules and
> > >     avoids DL
> > >     >     showing warnings.
> > >     >     >
> > >     >     > Maybe I should have noticed you before applying it, sorry. Hope
> > >     >     you understand why I made that change.
> > >     >     >
> > >     >     > Regards
> > >     >     >
> > >     >     > El mar., 10 mar. 2020 22:10, Rafael Fontenelle
> > >     <rafaelff gnome org <mailto:rafaelff gnome org>
> > >     >     <mailto:rafaelff gnome org <mailto:rafaelff gnome org>>> escribió:
> > >     >     >>
> > >     >     >> Hello Daniel,
> > >     >     >>
> > >     >     >> I notice you partially reverted the addition of LINGUAS to
> > >     >     >> release-notes, which might cause new translations added via
> > >     Damned
> > >     >     >> Lies to not be made available to the resulting
> > >     documentation. Can
> > >     >     >> please explain your reasons?
> > >     >     >>
> > >     >     >> Best regards,
> > >     >     >> Rafael Fontenelle
>
> _______________________________________________
> gnome-i18n mailing list
> gnome-i18n gnome org
> https://mail.gnome.org/mailman/listinfo/gnome-i18n