Re: Patches for Solaris and separate compilation

[davidk lysator liu se (David Kågedal)]

Raja R Harinath <harinath@cs.umn.edu> writes:

> > There was a symbol (some obstack function) used, which wasn't in
> > libc.  I found it in libiberty, and added -liberty to balsa_LDADD.
> 
> Not totally portable.  I think I'll add obstacks to gnomesupport.

Good idea.

> > builddir/sourcedir fix for control-center
> > 
> > Index: gnome-core/control-center/Makefile.am
> > ===================================================================
> > RCS file: /cvs/gnome/gnome-core/control-center/Makefile.am,v
> > retrieving revision 1.2
> > diff -u -r1.2 Makefile.am
> > --- Makefile.am	1998/08/12 18:51:57	1.2
> > +++ Makefile.am	1998/08/20 15:27:05
> > @@ -29,4 +29,4 @@
> >  
> >  $(CORBA_SRCLIST): control-center.idl
> >  	orbit-idl $(srcdir)/control-center.idl
> > -main.c: $(CORBA_SRCLIST)
> > +$(srcdir)/main.c: $(CORBA_SRCLIST)
> 
> Doesn't look right.  Are you using GNU make?  I think I'd fixed it by
> adding CORBA_SRCLIST to BUILT_SOURCES.

Yep.  GNU make 3.76.1.

> > Use strrchr instead of rindex.  This is just a workaround using a
> > define.  The hardcoded path names are changed too...
> 
> Should probably be edited s/rindex/strrchr/g.

Exactly.

> > @@ -190,8 +192,8 @@
> >          gtk_signal_connect( GTK_OBJECT (retval),"tree_select_row", GTK_SIGNAL_FUNC (selected_row_callback), NULL);
> >  
> >          /*hard_coded for now... */
> > -        global_node = read_directory ("/home/jrb/gnomedevel/test1");
> > -        user_node = read_directory ("/home/jrb/gnomedevel/test2");
> > +        global_node = read_directory ("/home/davidk/src/gnome/cc-test1");
> > +        user_node = read_directory ("/home/davidk/src/gnome/cc-test2");
> 
> Yuck.

:-)

-- 
David Kågedal        <davidk@lysator.liu.se> http://www.lysator.liu.se/~davidk/