Re: gnome-moz-remote problem

[Havoc Pennington <hp redhat com>]

On Mon, Nov 25, 2002 at 08:46:15AM +0000, Telsa Gwynne wrote:
> On Fri, Nov 22, 2002 at 11:52:28AM -0500 or thereabouts, jarrett duke edu wrote:
> > Hi All,
> > 
> > I attempt to run
> > 
> > gnome-moz-remote --raise
> > 
> > to get mozilla to pop up.  But, I get the following error:
> > 
> > X Error of failed request:  BadWindow (invalid Window parameter)
> >   Major opcode of failed request:  20 (X_GetProperty)
> >   Resourse id in failed request:  0x0
> >   Serial number of failed request:  22
> >   Current serial number in output stream:  22
> > 
> > Any suggestions?
> 
> This looks like an X error to me. 
>  

I would say 90% chance gnome-moz-remote is just broken. I had the
unfortunate experience of reading its source code recently.

Should also apply the appended patch, which may not be related.

Havoc

--- gnome-libs-1.4.1.2.90/libgnome/gnome-moz-remote.c.moz-remote-fix    2002-08-02 17:13:31.000000000 -0400
+++ gnome-libs-1.4.1.2.90/libgnome/gnome-moz-remote.c   2002-08-02 17:14:13.000000000 -0400
@@ -118,6 +118,12 @@
   unsigned long bytes_remain;
   unsigned char *prop, *prop2, *prop3;
                                                                                                                         
+  /* Having two code paths is dumb, just always do XQueryTree().  Also
+   * this code segfaults if no GNOME 1 WM is active.  Or with Metacity
+   * anyway.
+   */
+  return False;
+
   if (XGetWindowProperty(dpy, root,
                          XA_WIN_SUPPORTING_WM_CHECK, 0, 1, False, XA_CARDINAL,
                          &r_type, &r_format,