Re: Patches [was: Re: [gnome-love] Re: [gnome-love]Wow.]

[Dan Mueth <d-mueth uchicago edu>]

I usually go to the top level of the module and do a diff against what is
in CVS:

    cvs diff -uRN > CHANGES

This produces a very readable patch and merely lists filenames which have
appeared but are not in CVS.  Even better, if you keep your .cvsignore
files up-to-date (listing all generated files which don't belong in CVS),
then it doesn't even list any of the files which are generated :)

The only problem I see with using this for folks without CVS accounts is
that it may not handle new files which you create properly.  (If you have
a CVS account, you 'cvs add' them before doing your diff.)  I imagine
there is a flag to deal with this however.

Make sure you update the ChangeLog before doing your diff. The script
prepare-ChangeLog.pl is very helpful for this since it lists all of the
files you modified.

The Nautilus team uses these patches for almost every CVS commit since
we do patch review.

I'm not sure if these sort of things are documented anywhere.  If not,
perhaps we should discuss this in some introductory GNOME hacking document
which discusses the tools and conventions.  Does anybody know if such a
document exists?

Dan




On Wed, 23 May 2001, Josh Steiner wrote:

> Ok, I am assumeing that doing a diff like on a directory that will leave
> out files that exist in one directory but not another?  Ie, when i run the
> autogen.sh a bunch of files get created that obviously dont belong in the
> patch.
>
> Thanks,
>
> Josh
>
> On 23 May 2001, Miguel de Icaza wrote:
>
> > > How and in what way should we "ship" the patch?
> > >
> > > I'm assuming for directories,
> > > # diff -ur
> > > for single files
> > > # diff -u
> >
> > I am a fan of diff -ruN directory.old directory.new
> >
> > > Should we email the MAINTAINER or post to the list?
> > > Could you go over the proper protocol to use?
> >
> > I would say both.
> >
> > _______________________________________________
> > gnome-love mailing list
> > gnome-love gnome org
> > http://mail.gnome.org/mailman/listinfo/gnome-love
>
> _______________________________________________________________________
> Josh "Yoshi" Steiner - josh xiphoidprocess com - http://eds.org/~joschi
>
> Xiphoid Process Records - http://xiphoidprocess.com
> San Francisco based electronic music.
>
>
> _______________________________________________
> gnome-love mailing list
> gnome-love gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-love