[gnome-love] Re: ten maybe-possibly-fairly easy-fix bugs for new hacking volunteers

[Bill Haneman <bill haneman sun com>]

On Sat, 2002-04-20 at 16:40, Luis Villa wrote:
> The a11y team needs to get together with wipro and I, then... there have
> been a number of these types of dual-keybinding bugs filed and no one
> has commented adversely on any of them until Jacob did (which I admit I
> missed last night when I was making the list up.)

Hi:  (CC-ing release team)

Yes - and Abel, I didn't mean to say that the fix is
definitely 'bad', just that I'd like to see a second opinion.

Also the change to the accessibility capplet should probably 
be filed as a separate bugzilla bug with Calum included in the
interest list, otherwise interested parties won't know when 
labels and keybindings change.

This is a UI change too, so I'm sure there is a process that
should be followed before applying it since it could invalidate
documentation and screenshots...

Best regards,

-Bill

> Luis [trimming cc: list]
>
> On Sat, 2002-04-20 at 12:24, Bill Haneman wrote:
> > On Sat, 2002-04-20 at 06:37, R.I.P. Deaddog wrote:
> >
> > > > Without further ado:
> > > >
> > > > 1) two commands use same keyboard shortcut:
> > > > http://bugzilla.gnome.org/show_bug.cgi?id=75248
> > > [......]
> > >
> > > Item 1 done. Luckily this one doesn't require C skill at all *grin*
> > > Patched attached, and it fixes another duplicate shortcut key
> > > in Accessibility keyboard tab too. OK to commit?
> > >
> > > Abel
> >
> > I don't believe this is necessarily the right fix; please note
> > jacob berkman's comments from April 19.  He reports that the
> > correct behavior is currently available; i.e. pressing a
> > shortcut for which there are two actions cycles between the
> > actions.
> >
> > Thanks for not changing any accessibility keybindings without
> > getting the go-ahead from the accessibility team;
> >
> > in fact I think we should get input from Calum, Seth, etc.
> > (i.e. usability and keynav folks) before making any keybindings 
> > changes, even if they appear to be "fixes"
> >
> > thanks
> >
> > Bill
> > > > Luis
> > >
> > > -- 
> > > Abel Cheung
> > > GPG Key: (0xC67186FF) http://deaddog.org/gpg.asc
> > > ----
> >
> > > Index: capplets/keyboard/gnome-keyboard-properties.glade
> > > ===================================================================
> > > RCS file: /cvs/gnome/gnome-control-center/capplets/keyboard/gnome-keyboard-properties.glade,v
> > > retrieving revision 1.7
> > > diff -u -r1.7 gnome-keyboard-properties.glade
> > > --- capplets/keyboard/gnome-keyboard-properties.glade     18 Apr 2002 18:03:46 -0000      1.7
> > > +++ capplets/keyboard/gnome-keyboard-properties.glade     20 Apr 2002 05:31:38 -0000
> > > @@ -361,7 +361,7 @@
> > >                           <widget class="GtkCheckButton" id="cursor_toggle">
> > >                             <property name="visible">True</property>
> > >                             <property name="can_focus">True</property>
> > > -                           <property name="label" translatable="yes">_Cursor blinks in text 
> > > fields</property>
> > > +                           <property name="label" translatable="yes">C_ursor blinks in text 
> > > fields</property>
> > >                             <property name="use_underline">True</property>
> > >                             <property name="relief">GTK_RELIEF_NORMAL</property>
> > >                             <property name="active">False</property>
> > > Index: capplets/accessibility/keyboard/gnome-accessibility-keyboard-properties.glade2
> > > ===================================================================
> > > RCS file: 
> > > /cvs/gnome/gnome-control-center/capplets/accessibility/keyboard/gnome-accessibility-keyboard-properties.glade2,v
> > > retrieving revision 1.5
> > > diff -u -r1.5 gnome-accessibility-keyboard-properties.glade2
> > > --- capplets/accessibility/keyboard/gnome-accessibility-keyboard-properties.glade2        18 Apr 2002 
> > > 16:09:14 -0000      1.5
> > > +++ capplets/accessibility/keyboard/gnome-accessibility-keyboard-properties.glade2        20 Apr 2002 
> > > 05:31:39 -0000
> > > @@ -512,7 +512,7 @@
> > >                     <property name="visible">True</property>
> > >                     <property name="tooltip" translatable="yes">Perform multiple simultaneous key press 
> > > operations by pressing modifier keys in sequence.</property>
> > >                     <property name="can_focus">True</property>
> > > -                   <property name="label" translatable="yes">Enable _Sticky Keys</property>
> > > +                   <property name="label" translatable="yes">Enable St_icky Keys</property>
> > >                     <property name="use_underline">True</property>
> > >                     <property name="relief">GTK_RELIEF_NORMAL</property>
> > >                     <property name="active">True</property>