Re: [gnome-network] [PATCH] integrating the GST network tool with gnome-nettool

[Rodrigo Moya <rodrigo gnome-db org>]

On Wed, 2004-06-09 at 23:26 +0200, Carlos Garnacho wrote:
> Hi all,
> 
> 	Ive just readapted the good ol' patch for integrating nettool with
> network-admin from g-s-t with the current CVS code, it adds a
> "configure" button that displays a dialog for configuring that interface
> if network-admin is available, if it doesn't exist it just hides the
> button. it's OK to commit? :)

> +       if (gtk_combo_box_get_active_iter (combo, &iter)) {
> +               gtk_tree_model_get (model, &iter, 2, &nic, -1);
> +
> +               command_line = g_string_new (info->network_tool_path);
> +               g_string_append (command_line, " --configure ");
> +               g_string_append (command_line, nic);
> +
> +               g_spawn_command_line_async (command_line->str, NULL);
> +
here, I would add error processing, so that we can display an error
dialog if something goes wrong.

Apart from that, it looks ok to me, so please commit.

cheers