Re: [Gnome-print] Bug in gnome-print-check.m4

[Lauris Kaplinski <lauris ximian com>]

Hello Frederic!

Sorry, I remeber your e-mail but it slipped from my eye at some
point...
AFAIK it is OK, so commit it.

Best wishes,
Lauris Kaplinski

On 23 Jul 2001 10:08:43 +0200, Frederic Crozat wrote:
> Le 27 Jun 2001 11:40:31 +0200, Frederic Crozat a écrit :
> > Hi,
> > 
> > I've just found a bug in m4 macro for gnome-print detection, when no
> > default version is given...
> > 
> > Here is the patch :
> > 
> > --- gnome-common/macros/gnome-print-check.m4.orig     Mon Apr 16 11:30:54
> > 2001
> > +++ gnome-common/macros/gnome-print-check.m4  Wed Jun 27 11:35:51 2001
> > @@ -20,8 +20,8 @@
> >    else
> >      AC_MSG_CHECKING(for GNOME-PRINT - version >= $min_version)
> >      if `$GNOME_CONFIG --libs print > /dev/null 2>&1`; then
> > -      rqmajor=`echo "$1" | sed -e 's/cvs-//' | sed
> > 's/\([[0-9]]*\)\.\([[0-9]]*\).*/\1/'`
> > -      rqminor=`echo "$1" | sed -e 's/cvs-//' | sed
> > 's/\([[0-9]]*\)\.\([[0-9]]*\).*/\2/'`
> > +      rqmajor=`echo "$min_version" | sed -e 's/cvs-//' | sed
> > 's/\([[0-9]]*\)\.\([[0-9]]*\).*/\1/'`
> > +      rqminor=`echo "$min_version" | sed -e 's/cvs-//' | sed
> > 's/\([[0-9]]*\)\.\([[0-9]]*\).*/\2/'`
> >        major=`$GNOME_CONFIG --modversion print | sed -e
> > 's/gnome-print-//' | sed -e 's/cvs-//' | sed
> > 's/\([[0-9]]*\)\.\([[0-9]]*\).*/\1/'`
> >        minor=`$GNOME_CONFIG --modversion print | sed -e
> > 's/gnome-print-//' | sed -e 's/cvs-//' | sed
> > 's/\([[0-9]]*\)\.\([[0-9]]*\).*/\2/'`
> >        if test "$major" -ge "$rqmajor"; then
> > 
> > 
> > Can I commit in CVS ?
> 
> Still no response..
> 
> -- 
> Frédéric Crozat
> MandrakeSoft
> 
> 
> _______________________________________________
> Gnome-print maillist  -  Gnome-print@ximian.com
> http://lists.ximian.com/mailman/listinfo/gnome-print