[Gnome-print] Re: gnomeui stuff in libgnomeprintui
- From: Michael Meeks <michael ximian com>
- To: Havoc Pennington <hp redhat com>
- cc: <gnome-print ximian com>, <gnome-libs-devel gnome org>
- Subject: [Gnome-print] Re: gnomeui stuff in libgnomeprintui
- Date: Sun, 28 Oct 2001 18:52:15 -0500 (EST)
Hi Havoc,
> From configure.in libgnomeprintui doesn't appear to depend on
> libgnomeui, but then it does in the code, appended patch fixes it.
> It's just s/GNOME_PAD_SMALL/2/g and
> s/gnome_stock_button/gtk_button_new_stock/g.
>
> OK to commit?
Good catch - and point :-) however, I abhore the loss of
information in the patch. Can you create a LIBGNOMEPRINTUI_PAD_SMALL etc.
and commit that instead ? scattering '2' throughout the code doesn't seem
ideal to me. And then commit.
Many thanks,
Michael.
--
mmeeks@gnu.org <><, Pseudo Engineer, itinerant idiot
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]