Familiy name in Alias and alias brokeness.

[Chema Celorio <chema ximian com>]

I was looking at the issue that Radek brought up regarding aliases for
Familiy names and Akira's responses to the patch.

There are a number of issues with aliases in gnome-print right now, that
I've been meaning to fix after GNOME 2.2 goes out. I didn't wanted to
fix them at this point because "things worked" and it was too big of a
change to do so before the release. The reason aliases are like this is
from the move to fontconfig which was a quick move and I didn't had time
to polish it enough, needless to say gnome-print with fontconfig is much
much better than what it was before. What I think is important is to
keep the issues separate, this are the issues that I think we have:

1. - Family for aliases need to have the alias familyname, not the
font's familiy name. This is the bug reported by Radek. I've filed it
as:
http://bugzilla.gnome.org/show_bug.cgi?id=105006
and attached a patch:
http://bugzilla.gnome.org/showattachment.cgi?attach_id=14026

I'd like to get confirmation from Radek that the patch fixes his issue.

Also, Akira TAGOH said:
"Your patch breaks the printing, because psname is given from the ..."

I think Radek's patch doesn't introduce that problem, the problem is
there even without Radek's patch.

2. - Because alias entries are not recognized as aliases thru the code,
a font might be embeded twice, which was previously filed as:
http://bugzilla.gnome.org/show_bug.cgi?id=103436

3. - We are treating aliases inside the code as real fonts. There is
code that is using GP_FONT_ENTRY_ALIAS which we are no longer using when
loading the fontmap.

[chema lamark libgnomeprint]$ grep  GP_FONT_ENTRY_ALIAS *.c
gnome-font-face.c:                      if (entry->type == GP_FONT_ENTRY_ALIAS)
gnome-font-face.c:      if (face->entry->type == GP_FONT_ENTRY_ALIAS) {
gnome-font-face.c:      if (face->entry->type == GP_FONT_ENTRY_ALIAS) {
gnome-font-face.c:      if (face->entry->type == GP_FONT_ENTRY_ALIAS) {

I changed the code from using a entry type alias, to use a ->is_alias
flag. The reason for that is because I am preparing the move to pango
and having the fontmap know less about the fonts (like what format the
fonts are in) is going to be needed for the pango move. The way aliases
are being identified right now can be explained by:
http://bugzilla.gnome.org/showattachment.cgi?attach_id=13684

4. Another problem we have is that font aliases in gnome-print do not
match pango aliases names nor fontconfig's aliases name. We have 3
different group of strings. Gnome-print should have just used pango's
aliases and be done with it, but it wasn't done like that and font
aliases are part of the API, even if they are just strings. App
developers are going to have to use gnome-print's aliases and possibly
match them with pango aliases in their code, it sucks but we have to
keep the API stable.

I don't worry too much about this, because with the pango API for
gnome-print, app developers are not going to care about GnomeFonts at
all, they will just pass the Pango structures to gnome-print.

-----

Have i gotten the issues right? Feedback appreciated. I'd like to track
this issues in bugzilla as separate bugs as possible.

regards,
Chema