Re: canonicalization change broke eel check
- From: Alexander Larsson <alexl redhat com>
- To: nautilus-list gnome org, <gnome-vfs-list gnome org>
- Subject: Re: canonicalization change broke eel check
- Date: Wed, 14 Aug 2002 05:13:51 -0400 (EDT)
On Wed, 14 Aug 2002, Alexander Larsson wrote:
> The following change (i think) broke make distcheck in eel:
> 2002-07-15 Frederic Crozat <fcrozat mandrakesoft com>
>
> * libgnomevfs/gnome-vfs-uri.c: (set_uri_element):
> canonize NULL uri into "/". "start-here:" will now be
> canonized into "start-here:///", fixing some monitoring
> problem in nautilus
>
>
> make distcheck in eel breaks in the self-tests like this:
>
> running eel_self_check_vfs_extensions
>
> FAIL: check failed in eel-vfs-extensions.c, line 1870
> evaluated: eel_make_uri_canonical ("file:")
> expected: file:
> got: file:///
> FAIL: check failed in eel-vfs-extensions.c, line 1872
> evaluated: eel_make_uri_canonical ("glorp:")
> expected: glorp:
> got: glorp:///
> FAIL: check failed in eel-vfs-extensions.c, line 1928
> evaluated: eel_format_uri_for_display (":")
> expected: :
> got: :///
>
> eel_make_uri_canonical() that uses gnome_vfs_make_uri_canonical() is used
> a lot. Are we sure this behavorial change is correct everywhere? Nautilus
> may rely on the old behaviour somewhere.
In fact it broke nautilus distcheck too:
running nautilus_self_check_file
FAIL: check failed in ../../libnautilus-private/nautilus-file.c, line 5311
evaluated: nautilus_file_get_name (file_1)
expected: :
got: NULL
Which is:
file_1 = nautilus_file_get (":");
EEL_CHECK_STRING_RESULT (nautilus_file_get_name (file_1), ":");
nautilus_file_unref (file_1);
--
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
alexl redhat com alla lysator liu se
He's a lounge-singing devious firefighter with a mysterious suitcase
handcuffed to his arm. She's a mistrustful insomniac stripper living on
borrowed time. They fight crime!
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]