Re: Approval for no proxy patches

[Jonathan Blandford <jrb redhat com>]

mpeseng tin it writes:

> Hi,
> 
> I'd like to request permission to check in
> 
> http://bugzilla.gnome.org/show_bug.cgi?id=112979
> Teach gnome-vfs HTTP method to not use the proxy for some hosts
> (and add a gconf key to specify it)
> 
> http://bugzilla.gnome.org/show_bug.cgi?id=113222
> Implement the key in epiphany
> 
> Alex would like the gnome vfs patch to be checked in too. It adds a string
> but should not bother translators becuase gnome-vfs schemas are not translated.
> The feature is quite necessary for a lot of people. Unfortunately there
> is still not an user interface for it, I guess that will have to wait post
> 2.4.

Reading through both patches, I have a couple comments:

 * We should definitely commit the schemas change whether or not any of
   the code changes happens.  It seems clear that we need the key in
   GNOME, and epiphany having its own temporary key is a bad idea.

 * I'm a tiny little concerned that you don't actually check any of the
   strings you get from the key before passing them to mozilla in the
   epiphany patch.  Also, it doesn't look like you handle the empty set
   case at all, and are counting on mozilla handling what you pass it.
   In theory, I'm happy with a patch to epiphany to handle the GConf
   key.

 * The patch to gnome-vfs is more scary, and I'm less thrilled with
   it. I'd really like to hear from Alex and Teuf on whether or not it's
   worth pushing this in.

Thanks,
-Jonathan