Re: Approval for no proxy patches

[Marco Pesenti Gritti <mpeseng tin it>]

Il mer, 2003-08-06 alle 16:47, Mark McLoughlin ha scritto:
> Hi Marco,
> 
> On Wed, 2003-08-06 at 15:06, mpeseng tin it wrote:
> > Hi,
> > 
> > I'd like to request permission to check in
> > 
> > http://bugzilla.gnome.org/show_bug.cgi?id=112979
> > Teach gnome-vfs HTTP method to not use the proxy for some hosts
> > (and add a gconf key to specify it)
> > 
> > http://bugzilla.gnome.org/show_bug.cgi?id=113222
> > Implement the key in epiphany
> > 
> > Alex would like the gnome vfs patch to be checked in too. It adds a string
> > but should not bother translators becuase gnome-vfs schemas are not translated.
> > The feature is quite necessary for a lot of people. Unfortunately there
> > is still not an user interface for it, I guess that will have to wait post
> > 2.4.
> 
> 	My gut instinct is to say no, this should be punted until 2.6. Adding a
> large-ish feature to a base library, which is required by another
> application, at this late stage, makes me a bit nervous. But I'll admit
> I'm probably being more anal than most.
> 
> 	This isn't really a serious issue for epiphany anyway is it? There is
> support for this in epiphany already, all the epiphany patch does is use
> the /system GConf key rather than the /apps/epiphany key. So really, so
> we're not missing this functionality in the browser if the patch doesn't
> get it.

Jonathan gave his approval to check in both patches, but they should be
in for Beta1. Teuf will do a gnome-vfs release if the patch is approved.

We need another release team member to approve it (Mark I guess, since
he already looked at the issue).

Part 1: Epiphany patch + gnome-vfs schemas patch (add the required key)

The epiphany patch is quite simple, it just mirror the gconf value in
mozilla configuration, I dont think we risk bugs.

Part 2: Gnome vfs support

Both Teuf and Alex thinks it would be good to check it in and reviewed
the patch a while ago. There is not user interface for it anyway, so the
risk should be low.

Sorry to be posting again, but we are in a hurry because Beta1 is on
Monday. If you are worried by part 2 (or even by part 1), I can live
with delaying this post 2.4. Just trying to do this in time, if it can
be done.

Thanks

Marco