Re: [patch] fstab-sync mount point names

[Frederic Crozat <fcrozat mandrakesoft com>]

Le mardi 31 août 2004 à 09:10 +0200, Alexander Larsson a écrit :
> On Mon, 2004-08-30 at 19:24, David Zeuthen wrote:
> > On Mon, 2004-08-30 at 19:16 +0200, David Zeuthen wrote:
> > > Hi Alex,
> > > 
> > > This simple patch adds some more heuristics to recognize the mount point
> > > names generated by fstab-sync. Also, this patch uses the some of new and
> > > cool icons Jimmac put in gnome-icon-themes. You can find a screenshot
> > > right here 
> > > 
> > 
> > Attached is an improved version that fixes one leak compared to the
> > inital patch. Doh!
> 
> The patch looks fine to me, but it adds strings, so it can't go into 2.8
> as is, even with release-team approval. We could probably get the
> non-stringchanging parts into cvs, as they are pretty simple to review
> and don't affect stability.
> 
> release-team, is this patch ok for gnome 2.8? All it does is recognize
> some mountpoint names that HAL creates and give them more descriptive
> icons. (The icons are alreay in gnome-icon-theme.)
> 
> For fedora, i guess we'll have the string-additions as an extra patch in
> the rpm.

Well, if we can see the patch, maybe :)

-- 
Frederic Crozat <fcrozat mandrakesoft com>
Mandrakesoft