Re: url-encoding for http addresses



Hi,

Am Freitag, den 10.12.2004, 22:46 -0500 schrieb Walter Landry:
> Alexander Larsson <alexl redhat com> wrote:
> > On Mon, 2004-12-06 at 20:38 -0500, Walter Landry wrote:
> > > Hello,
> > > 
> > > I just upgraded gnome-vfs2 on my Debian testing machine from 2.6.2 to
> > > 2.8.3, and it seems that the default interpretation of http uri's has
> > > changed.  In 2.6, gnome-vfs2 breaks if you don't url-encode any http
> > > uri's you give it.  In 2.8, it breaks if you do.
> > > 
> > > First of all, is this change documented anywhere?  Second, is there a
> > > simple way to check for versions so that I can write code that will
> > > work with both the old and new conventions?
> > 
> > Hmm. This sounds bad. You mean that passing in a string containing "%20"
> > breaks, but one with a space in doesn't? That seems wrong, the gnome-vfs
> > semantics should be that uris always have to be escaped.
> 
>   $ gnomevfs-ls http://superbeast.ucsd.edu/~landry/ArX/wlandry/arx/2/1/,cache/
>   arx.2.1,59.tar.gz               (Regular, application/x-tar)    size 784886mode 0000
>   $ gnomevfs-ls http://superbeast.ucsd.edu/~landry/ArX/wlandry/arx/2/1/%2Ccache/
>   Segmentation fault

bug in http-neon-method.c [I tested with gnome-vfs 2.8.3] (HEAD doesnt
have http-neon-method.c anymore)
function do_open_directory

pfctx... propfind context

by default pfctx->* = NULL

then there is this check:
        if (result == GNOME_VFS_ERROR_NOT_SUPPORTED ||
            (result == GNOME_VFS_OK && (pfctx->target->type
             != GNOME_VFS_FILE_TYPE_DIRECTORY))) {
         
                result = GNOME_VFS_ERROR_NOT_A_DIRECTORY;
        }

pfctx->target is NULL. dereference. boom.

cheers,
   Danny

-- 
www.keyserver.net key id A334AEA6

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]