Re: [PATCH] eject improvement - Nautilus bugzilla # 151840.

[Magnus Damm <magnus damm gmail com>]

Alex, List,

On Wed, 15 Dec 2004 09:47:57 +0100, Alexander Larsson <alexl redhat com> wrote:
> On Sat, 2004-12-04 at 13:55 +0100, Magnus Damm wrote:
> > Hello,
> >
> > Apple machines tend to miss eject buttons on cdrom-drives. This
> > together with some types of media can put the user in a bad situation:
> >
> > DVD:s
> > xine and mplayer both play DVD:s without mounting them. My patches
> > makes it possible to eject the DVD media without prior mounting.
> >
> > Audio CD:s
> > My kernel does not allow me to mount audio CD:s. Without the patches,
> > it is impossible to eject an audio CD with nautilus because the media
> > is unmountable by the kernel. The user has to start a terminal and use
> > the eject command. Not very user friendly. This probably applies to
> > all media that is unsupported (not mountable) by the kernel.
> 
> The current hal-based code does actually create volumes even for audio
> cds, so you can unmount it. But i see the problem.

Good!

> Btw, how do you "eject" an empty cdrom on the apple machine in osx so
> that you can insert a CD?

My Apple machine (maybe all?) has a slot in drive, so there is no need
to eject to insert new a CD.

> > The attached patches contain the following changes:
> >
> > gnome-vfs: makes it possible to eject unmounted media. bugfixes.
> > nautilus: adds right-click eject on removable media.
> >
> > The gnome-vfs patch also fixes the following:
> >
> > gnome-vfs-volume-ops.c, gnome_vfs_drive_eject():
> > current_vol->next should be used instead of current_vol.
> >
> > gnome-vfs-volume-ops.c, mount_unmount_thread():
> > Memory leak if umount fails but eject succeeds.
> > My fix (refuse to eject if umount fails) might conflict with bugzilla #143569
> 
> Yes. It seems to conflict. Could you change it so it tries eject even if
> the unmount fails? Otherwise the gnome-vfs parts look ok, and we should
> get that in.

I will see what I can do during the weekend(s).

> For the nautilus patch, I didn't try it, but it seems that it adds both
> the "eject" and an "unmount" item to the menu. I don't like that, as it
> unnecessary exposes the unmount operations for something that doesn't
> need it (when do you unmount but not eject a cd?) and makes the menu
> larger than necessary.

Hm.

Can we agree on that eject for unmounted removable drives is good? If
so, then unmounted removable drives have both "mount" and "eject" in
the menu.

I think that both "eject" and "unmount" are useful for me as a power
user. Maybe it is confusing for grandma to see "mount" and "unmount"
but she will already see "mount" so why not let her see "unmount" too
- this just to not limit power users.

And if "mount" and "eject" is ok for unmounted removable drives, then
"unmount" and "eject" takes up the same amount of space in the menu...

If you want to reduce the size of the menu I think something less
useful than "unmount" could be removed like "Make Link", "Rename" or
"Move to trash"...
But I am no gui guru so what do I know? =)

> Also, the nautilus patch totally doesn't apply to the new bonobo-ui less
> version of the code.

Is it the same file, just a newer version, or should I patch some other file?

> > Sorry for not producing patches against CVS, but I do not know where
> > to checkout from...
> 
> http://developer.gnome.org/tools/cvs.html
> 
> module "gnome-vfs" and "nautilus".

Ok.
Let me know what you think, thanks!

/ magnus