Re: One to many (Dirves to Volumes) patch round 1

["John (J5) Palmieri" <johnp redhat com>]

On Mon, 2004-07-12 at 14:37 -0400, John (J5) Palmieri wrote:
> Here is the first round of API changes for Gnome-VFS and making one
> drive able to describe more than one volume (i.e. multiple partitions,
> multisession CDs, etc.).  Basically this patch changes the
> GnomeVFSVolume *volume member in the GnomeVFSPrivateDrive struct to be
> GList *volumes and then changes the API to accommodate the list (i.e.
> set methods become add methods).  Right now this does not add any new
> functionality but serves as the basis for the one-to-many change
> (Bugzilla bug 143888).  It lays the foundation while making sure gnome-
> vfs still works as expected before I start integrating the actual code
> to do multiple volumes per drive using hal.  If anyone sees any glaring
> mistakes please let me know.
> 
> One issue that I am not sure how to deal with is the get_data_for_drive
> method which searches the volume for info on the drive if the volume
> exists.  That is fine if there is only one volume but which volume do
> you use if there are more than one?  
> 
> Attached is the patch against CVS.  Comments welcome.  I would
> especially like to know if I did the Corba stuff correctly.  It was my
> first time actually using Corba directly and I wanted to make sure I
> didn't miss anything.
> 
> _______________________________________________
> gnome-vfs-list mailing list
> gnome-vfs-list gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-vfs-list

It has been brought to my attention that the Corba code may not be
internal and therefor my changes would break API/ABI compatibility.  I
need to know if the API is internal and therefor does not need to keep
compatibility.  If it is external I am formulating a plan which I will
implement if needed. 


-- 
John (J5) Palmieri
Associate Software Engineer
Desktop Group
Red Hat, Inc.
Blog: http://martianrock.com