gnome-vfs freeze break request - smb directory type
- From: Alexander Larsson <alexl redhat com>
- To: "gnome-vfs-list gnome org" <gnome-vfs-list gnome org>, "release-team gnome org" <release-team gnome org>
- Cc:
- Subject: gnome-vfs freeze break request - smb directory type
- Date: Mon, 06 Sep 2004 10:54:49 +0200
There is a small bug in the smb backend. When readdir a location like
smb://<server> it returns a directory (type ==
GNOME_VFS_FILE_TYPE_DIRECTORY) with a mimetype of "x-directory/smb-
share".
Unfortunately, even though it sets the type, it forgets to set the
GNOME_VFS_FILE_INFO_FIELDS_TYPE flag in "valid_fields". This means that
nautilus will not be able to open the directory, because it doesn't
think the file is a directory.
Very simple patch:
Index: modules/smb-method.c
===================================================================
RCS file: /cvs/gnome/gnome-vfs/modules/smb-method.c,v
retrieving revision 1.8
diff -u -p -r1.8 smb-method.c
--- modules/smb-method.c 25 Aug 2004 17:22:18 -0000 1.8
+++ modules/smb-method.c 6 Sep 2004 08:46:13 -0000
@@ -1709,7 +1709,8 @@ do_read_directory (GnomeVFSMethod *metho
switch (entry->smbc_type) {
case SMBC_FILE_SHARE:
file_info->valid_fields = file_info->valid_fields
- | GNOME_VFS_FILE_INFO_FIELDS_MIME_TYPE;
+ | GNOME_VFS_FILE_INFO_FIELDS_MIME_TYPE
+ | GNOME_VFS_FILE_INFO_FIELDS_TYPE;
file_info->type = GNOME_VFS_FILE_TYPE_DIRECTORY;
file_info->mime_type = g_strdup ("x-directory/smb-share");
break;
Ok to commit?
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
alexl redhat com alla lysator liu se
He's an uncontrollable flyboy waffle chef whom everyone believes is mad. She's
an orphaned impetuous socialite looking for love in all the wrong places. They
fight crime!
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]