Re: [PATCH] gnome_vfs_uri_extract_short_name() should never return NULL
- From: "Vincent Untz" <vincent vuntz net>
- To: "Alexander Larsson" <alexl redhat com>
- Cc: gnome-vfs-list gnome org
- Subject: Re: [PATCH] gnome_vfs_uri_extract_short_name() should never return NULL
- Date: Fri, 28 Jan 2005 15:25:20 +0100 (CET)
On Tue, January 25, 2005 12:47, Alexander Larsson said:
> On Mon, 2005-01-24 at 12:13 +0100, Vincent Untz wrote:
>> A patch is available at
>> http://bugzilla.gnome.org/attachment.cgi?id=35337&action=view
>> With the patch, we return the hostname if short_path_name is NULL or if
>> it's /. And we never return NULL.
>>
>> I forgot to add a ChangeLog entry in the patch, but I'll do it if it's
>> okay to commit.
>
> You seem to leak in the final else clause. Otherwise it looks good to
> me.
Sorry for the delay...
I must be blind because I don't see the leak :-)
Vincent
--
Les gens heureux ne sont pas pressés.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]