Re: [PATCH] Fix FTP/SFTP authentication cancellation

[Alexander Larsson <alexl redhat com>]

On Fri, 2005-10-07 at 20:47 +0200, Christian Neumair wrote:
> The attached patch is meant to fix FTP/SFTP (and finally, SMB and HTTP)
> authentication issues. Together with a patch to Nautilus (work in
> progress, just needs some cleanups), it will take care that a cancelled
> authentication request is not displayed again.

        init_authentication (&actx, NULL);
+       g_warning ("performing authentication");

Kill that.

 static gboolean
-prompt_authentication (SmbAuthContext *actx)
+prompt_authentication (SmbAuthContext *actx,
+                      gboolean       *cancelled)

This isn't fixing all uses of the old non-pointer cancelled variable.
(In particular, it breaks the return value at the end.)

Otherwise this looks nice.

> c) I refuse to work on the non-Neon HTTP method because it should IMHO
> die a sudden death

Yeah, is there a reason we haven't removed this? gicmo?

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a time-tossed guerilla photographer looking for a cure to the poison 
coursing through his veins. She's a cynical extravagent single mother from a 
different time and place. They fight crime!