Approval for small change in gnome-vfs' http neon method
- From: Christian Kellner <gicmo gnome org>
- To: release-team gnome org
- Cc: "gnome-vfs-list gnome org" <gnome-vfs-list gnome org>
- Subject: Approval for small change in gnome-vfs' http neon method
- Date: Thu, 31 Aug 2006 10:34:47 -0700
Hey release team,
Matthias spotted a nasty little bug in http neon method which gets
triggered if the number of maximum (http) redirects is reached. In a few
places we try to translate the neon result code into a GnomeVFSResult
_after a call to http_follow_redirect_ which will hit an assertion. We
of course shouldn't be trying to resolve the neon result code but
instead just return the GnomeVFSResult we got from http_follow_redirect
in case of an error. The little patch[1] of mine does that. It only
changes a few places which are touched when redirects happen and its
nothing complicated but its a "crash" (g_assert_not_reached) so I would
rather get rid of it! The bugzilla.gnome.org bug is 353337[2].
Cheers,
Christian
[1] http://bugzilla.gnome.org/attachment.cgi?id=71918&action=view
[2] http://bugzilla.gnome.org/show_bug.cgi?id=353337
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]