Re: [PATCH] Allow to set username on NULL username SFTP login

[Christian Neumair <chris gnome-de org>]

Am Montag, den 14.08.2006, 12:59 +0200 schrieb Alexander Larsson:
> On Sat, 2006-08-12 at 14:12 +0200, Christian Neumair wrote:
> > The attached patch is meant to fix bug 350111 [1] by allowing to change
> > the login name when no username is specified in an SFTP URI.
> > 
> > Caveats:
> > 
> > (a) this might break some special non-interactive login methods because
> > we always pass "-l" to the SSH client. I'm not an expert for this,
> > though, maybe sb. else knows better whether this can become a problem?
> > We already use
> > 
> >   if (user_name == NULL)
> >     user_name = g_get_user_name ();
> > 
> > in sftp_get_connection, so we seem to make special assumptions about the
> > authentication method. Do we support private key authentication ATM?
> 
> I have no idea really. Lets get it in for now and see if we get any
> complaints. :)
> 
> Anyway, the patch looks good to commit (assuming you tested it
> reasonably well).

Done. It doesn't seem to interfere with pubkey auth.

-- 
Christian Neumair <chris gnome-de org>