Re: [PATCH] use pmount instead of mount for hotpluggable device

[Alexander Larsson <alexl redhat com>]

On Wed, 2006-02-15 at 10:40 +0100, Christian Neumair wrote:
> Am Montag, den 13.02.2006, 11:07 -0500 schrieb David Zeuthen:
> > On Mon, 2006-02-13 at 10:02 +0100, Alexander Larsson wrote:
> > > On Sun, 2006-02-12 at 22:34 +0100, Christian Neumair wrote:
> > > > Without this patch I'm unable to mount previously unmounted hotpluggable
> > > > devices again using gnome-vfs/nautilus. The successful first time pmount
> > > > is probably done by the gnome-volume-manager.
> > > 
> > > I'd like to have feedback from the utopia people on this, because I
> > > don't really know how this is supposed to work. It strikes me as strange
> > > to assume /media uses pmount, because clearly not everyone does that.
> > > Although they probably don't have pmount installed, so it might be ok.
> > 
> > So I'm not sure whether this patch breaks anything (because I haven't
> > tested it) but this seems pretty weird
> 
> Hrm punmount is as of writing used if the "/media" check passes as well,
> so that behavior should also be changed, right?

Maybe its more safe to use it for unmount, i.e. if it falls back to
umount. Anyway, I think this is wrong. We shouldn't be mixing the
various helpers.

I'm applying a patch that makes the gnome-mount and hal-mount cases
never use pmount, but the fallback case uses pmount if its installed.
Could you verify that it works for you Christian?

I don't think this is really right either. We should probably have a
--enable-pmount setting, but i don't want to change that at this late
point.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a lounge-singing umbrella-wielding ex-con on a mission from God. She's a 
time-travelling nymphomaniac mercenary in the wrong place at the wrong time. 
They fight crime!